Fix negative streak handling in getFreebuffStreakGlmWeeklyUnits - #1233
Open
pavankumar-vh wants to merge 1 commit into
Open
Fix negative streak handling in getFreebuffStreakGlmWeeklyUnits#1233pavankumar-vh wants to merge 1 commit into
pavankumar-vh wants to merge 1 commit into
Conversation
The function didn't validate that streak is non-negative. If streak was negative, Math.floor(streak / INTERVAL) would be negative, and Math.min with the positive max would return the negative value, resulting in a negative GLM bonus. Added Math.max(0, streak) to ensure streak is non-negative before processing.
Contributor
|
Thanks for the contribution - the fix itself is small, correct, and in-scope ( The logic checks out: A few things that would make this more mergeable:
As-is, it's not wrong, just under-verified for a numeric edge case fix. Add the test and clarify whether this was found via a real negative streak value in production, and it should be an easy 3-line port. |
codebuff-team
added
bot:triaged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fix negative streak handling in the
getFreebuffStreakGlmWeeklyUnitsfunction incommon/src/util/freebuff-streak.ts.Bug Description
The function didn't validate that streak is non-negative. If streak was negative,
Math.floor(streak / INTERVAL)would be negative, andMath.minwith the positive max would return the negative value, resulting in a negative GLM bonus.Fix
Added
Math.max(0, streak)to ensure streak is non-negative before processing.Testing
All existing tests pass (14/14).
Files Changed
common/src/util/freebuff-streak.ts- Added negative streak validationScope
This change only touches
common/which is an approved contribution area per the Contributing Guide.